Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log an exception if it happened not just in a step but in a test method as well #90

Merged
merged 1 commit into from
Mar 1, 2020
Merged

Conversation

pavelsmolensky
Copy link

In cases like this
@Test
public void someTest(){
someStep.doSomething();
assertThat(%whatever%).isEqualTo(%whatever_else%)
}
if assertion in the last line fails, it doesn't appear in report portal.
This PR is aimed to fix it.

@Invictum Invictum changed the base branch from master to develop December 13, 2019 03:10
@Invictum Invictum added this to the 1.4.3 milestone Dec 13, 2019
@Invictum
Copy link
Owner

@pavelsmolensky
Thanks for the contribution! PR will be reviewed in a few days.

@Invictum Invictum merged commit fbba1f1 into Invictum:develop Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants